HelloZeroNet/ZeroNet

ZeroNet seems to bomb Tor's SOCKS port with non-SOCKS requests

Open

#1243 opened on Jan 15, 2018

View on GitHub
 (5 comments) (1 reaction) (1 assignee)JavaScript (18,200 stars) (2,245 forks)batch import
help wanted

Description

I run ZeroNet in --tor always mode. When ZeroNet is running, a lot of such log records appear in Tor's log:

Jan 14 23:37:43.000 [warn] Socks version -125 not recognized. (This port is not an HTTP proxy; did you want to use HTTPTunnelPort?)
Jan 14 23:37:43.000 [warn] Fetching socks handshake failed. Closing.

Stopping ZeroNet stops these errors too. zeronet-0.6.0 tor-0.3.2.9 FreeBSD 11.1

Contributor guide

Tech stack
javascript
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Understanding of Tor SOCKS protocolFamiliarity with ZeroNet's Tor configuration
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate ZeroNet's Tor proxy implementation, specifically the code handling SOCKS handshake (likely in Connection or TorManager files). Check if ZeroNet is incorrectly sending HTTP requests to the SOCKS port. Review comments from the issue for any hints. Consider fixing the SOCKS handshake to properly negotiate version 5 or reject invalid requests.