Hammerspoon/hammerspoon

Light sensor doesn't works on macbook with touchbar

Open

#1673 opened on Feb 5, 2018

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Objective-C (15,415 stars) (688 forks)batch import
bugdocshelp wanted

Description

Looks like we don't have AppleLMUController from https://github.com/Hammerspoon/hammerspoon/commit/66c208d5e72f16afd891ca36233c466e338be394 anymore for macbooks with touch bar :(

Contributor guide

Tech stack
objective clua
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Objective CmacOS system APIsIOKitHammerspoon internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Examine the referenced commit 66c208d to understand the previous implementation of AppleLMUController. Investigate the IOKit framework for changes in the AppleLMUController interface on MacBooks with Touch Bar. Search the current Hammerspoon source for light sensor handling and check IORegistry on a Touch Bar MacBook to verify sensor presence. Discuss findings with maintainers.