HabitRPG/habitica

Refactor Justin intro modal to separate it from avatar edit

Open

#10803 opened on Nov 2, 2018

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (10,775 stars) (3,912 forks)batch import
help wantedpriority: minorsection: Avatar/User Modal

Description

Description

creatorIntro.vue is used both for initial avatar setup on account creation, and for editing a user's avatar via the user menu. This makes it difficult to consistently position both modals, because ideal positioning for the Justin sequence pushes the much larger avatar edit modal partially offscreen.

What we should do is pull the shared avatar-related pieces out to a component that's then plugged into two separate modals, Justin and post-setup avatar editing. Then, reposition the Justin sequence so it's centered better onscreen.

Contributor guide

Tech stack
vuejavascript
Domain
frontend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Vue.jsunderstanding of component refactoringknowledge of modal UI patterns
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the current `creatorIntro.vue` component to understand how it handles both the Justin intro and avatar editing. Identify the shared avatar related pieces (likely the avatar preview and controls) that can be extracted into a separate component. Then, create two new modals: one for the Justin sequence and one for post setup avatar editing, each using the shared component. Ensure the Justin sequence modal is repositioned to be centered on screen.