GroceriStar/groceristar-fetch

update at getGroceriesWithDepIngKey tests

Open

#217 opened on Feb 9, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (16 forks)auto 404
enhancementgood first issuehelp wantedin-progresstests

Repository metrics

Stars
 (8 stars)
PR merge metrics
 (PR metrics pending)

Description

file: https://github.com/GroceriStar/groceristar-fetch/blob/master/projects/GroceriStar/getGroceriesWithDepIngKey.test.js

  • tests that checking properties - move to a separated function. you can read our other test files and find a solution.

  • Right now these tests didn't cover a lot of cases. Try to jump on grocery.json and delete an id property. Try to delete name, make name an empty string. Delete all data from one object, only keep id, name(no departments, no ingredients inside)

  • ingredients for grocery lists stored at Ingredients folder. they connected via file name. just delete one of the files, that should be connected to grocery and you wouldn't see an error.

  • Test Deep structure takes 6000ms how to reduce this number?

  • we have test Ingredient by length? WTF it's doing and why we need it - please explain.

  • making grocery list name as empty string didn't generate an error

@shubhamrajput it's for you

Contributor guide

Research direction
Start by examining the existing test file for getGroceriesWithDepIngKey. Understand the structure of grocery.json and the Ingredients folder. For each subtask, write a separate test function. To reduce test time for deep structure, consider mocking or optimizing data. Investigate the 'Ingredient by length' test to determine its purpose and necessity. Ensure to test edge cases like missing properties, empty strings, and missing ingredient files.
Tech stack
javascript
Domain
backend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65