GrenderG/Toasty

not showing properly in phones with smaller display

Open

#94 opened on Dec 11, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Java (6,535 stars) (822 forks)batch import
can't reproducehelp wanted

Description

First of all, thanks for this amazing library. But its not showing properly in smaller display phones. Here's some screenshots:

screenshot_20181211-125645 This was the code: Toasty.error(this, "Failed GsignIn", Toast.LENGTH_SHORT, true).show();

and

screenshot_20181211-125927 This was the code: Toasty.info(this, "Loading. Please wait...", Toast.LENGTH_SHORT, true).show();

Tested in Sony Ericsson Xperia Mini (160dpi) Android 7.1.2

Thanks in advance...

Contributor guide

Tech stack
javaandroid
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Android SDK basicsJavaunderstanding of screen densities
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the Toasty source code, specifically the custom toast view layout (likely in Toasty.java or XML layout files). The issue is that text does not fit on small screens (160dpi). A fix could involve making the toast layout responsive using density independent dimensions (dp, sp) or adjusting text size based on screen width. Check if any previous comments or PRs address this. Implement a solution that ensures the toast remains fully visible on small displays.
not showing properly in phones with smaller display · GrenderG/Toasty#94 | Good First Issue