Graylog2/graylog2-server

Don't sort output config fields by optionality

Open

#4,761 opened on Apr 25, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Java (1,032 forks)batch import
good first issuepapercuttriaged

Repository metrics

Stars
 (6,945 stars)
PR merge metrics
 (Avg merge 8d 19h) (297 merged PRs in 30d)

Description

Expected Behavior

The config fields of my output plugin appear in the order I registered them.

Current Behavior

If some of them are optional, they are shown below all others.

Possible Solution

Don't sort the fields by optionality.

Steps to Reproduce (for bugs)

Register two output config fields and make the first optional.

Context

https://github.com/Graylog2/graylog2-server/pull/4746#issuecomment-384253076

Your Environment

(not relevant)

Contributor guide

Research direction
Open the ConfigurationForm.jsx file, locate line 156, and remove or modify the sort function that sorts fields by optionality.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90