Graylog2/graylog2-server

Don't sort output config fields by optionality

Open

#4761 opened on Apr 25, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Java (6,945 stars) (1,032 forks)batch import
good first issuepapercuttriaged

Description

Expected Behavior

The config fields of my output plugin appear in the order I registered them.

Current Behavior

If some of them are optional, they are shown below all others.

Possible Solution

Don't sort the fields by optionality.

Steps to Reproduce (for bugs)

Register two output config fields and make the first optional.

Context

https://github.com/Graylog2/graylog2-server/pull/4746#issuecomment-384253076

Your Environment

(not relevant)

Contributor guide

Tech stack
javajavascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with React componentsunderstanding of Graylog configuration forms
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
The issue is in the ConfigurationForm.jsx component, specifically at line 156 where fields are sorted by optionality. The fix is to remove or modify this sorting to preserve the original registration order. Refer to linked PR #4746 and comment for context. No additional changes to other parts of the codebase are required.