Graylog2/graylog2-server

Pipeline stream connections are not deleted when deleting a pipeline

Open

#21008 opened on Nov 20, 2024

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Java (6,945 stars) (1,032 forks)batch import
buggood first issuetriaged

Description

When deleting a pipeline, all dependent data should also be deleted. In particular for collection pipeline_processor_pipelines_streams:

  • delete the pipeline ID from all pipeline_ids lists
  • delete the entire document, if the deleted pipeline ID was the only one in that connection

Caveat: never delete the default stream connection of the default routing pipeline "All Messages Routing". See Graylog2/graylog-plugin-enterprise/issues/9589 for context.

Current Behavior

Obsolete connection documents remain in the DB.

Steps to Reproduce (for bugs)

  1. Create a pipeline and connect it to a stream
  2. Delete the pipeline
  3. Observe that the pipeline ID is still part of a connection document

Your Environment

  • Graylog Version: 6.2

Contributor guide

Tech stack
javamongodb
Domain
backenddatabase
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaMongoDBGraylog pipeline concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the pipeline deletion logic in the Graylog backend. Look for the service that handles pipeline deletion and ensure that after removing a pipeline, the associated stream connections in collection 'pipeline processor pipelines streams' are also cleaned up. Check the caveat for the default stream connection of 'All Messages Routing' as referenced in the enterprise plugin issue. Examine the existing tests to understand expected behavior and add unit tests for this scenario.