GraphiteEditor/Graphite

Box/lasso selection should be compatible with PTZ

Open

#2,391 opened on Mar 7, 2025

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Rust (25,662 stars) (1,176 forks)batch import
Good First IssuePaper Cut

Description

Box selection with the Select tool and Path tool doesn't follow the canvas when panning (via the mouse vertical/horizontal scroll wheel) or zooming (with Ctrl + or Ctrl -). The starting point of the rectangle should be locked down to the canvas location, not follow the viewport. This works correctly with the auto-panning feature (dragging the box selection off the edges of the viewport), so that code can be referenced. The actual box selection must still be rounded to viewport coordinates so the box selection is drawn cleanly (without fuzzy antialiasing). The video below shows the incorrect present behavior.

https://github.com/user-attachments/assets/6687128d-0123-4feb-bd10-88c36440971d

Discussion in this Discord thread: https://discord.com/channels/731730685944922173/1321358747133677599

Contributor guide

Tech stack
rust
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic knowledge of RustUnderstanding of coordinate transforms
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Examine the code for auto panning behavior (likely in the selection tool module) to understand how it locks the starting point to canvas coordinates. Then, modify the box/lasso selection logic to similarly lock the rectangle's origin during pan and zoom while still rounding coordinates for clean rendering. The relevant code is likely in the 'editor' or 'tool' modules. Refer to the video and Discord discussion for context.