GraphiteEditor/Graphite

Ctrl+Z on 'Edit > Convert to Infinite Canvas' creates leftover merge nodes

Open

#2,258 opened on Feb 3, 2025

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Rust (25,662 stars) (1,176 forks)batch import
Good First Issue

Description

https://github.com/GraphiteEditor/Graphite/blob/6d52151d6067627caf618e6167636108dfc0d6f4/editor/src/messages/portfolio/document/graph_operation/graph_operation_message_handler.rs#L205

Undoing Edit> Convert to Infinite Canvas (formerly called 'Clear Artboards') with Ctrl+Z leaves N merge nodes which doesn't seem logical given where transaction added.

https://github.com/user-attachments/assets/2db0178c-b08a-47c3-b71f-712ddcf15e21

Contributor guide

Tech stack
rust
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The issue is in the Graphite editor's undo handling of the 'Convert to Infinite Canvas' operation. The bug occurs in the `graph operation message handler.rs` file at line 205. The fix likely involves ensuring that the undo transaction properly cleans up merge nodes when undoing the conversion. The issue provides a video showing leftover merge nodes after Ctrl+Z. No existing comments or PRs. The contributor should examine the undo/redo logic in that file and test the specific sequence: Edit > Convert to Infinite Canvas followed by Ctrl+Z.