GraphiteEditor/Graphite

Ctrl+Z on 'Edit > Convert to Infinite Canvas' creates leftover merge nodes

Open

#2,258 opened on Feb 3, 2025

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Rust (1,176 forks)batch import
Good First Issue

Repository metrics

Stars
 (25,662 stars)
PR merge metrics
 (Avg merge 6d 9h) (65 merged PRs in 30d)

Description

https://github.com/GraphiteEditor/Graphite/blob/6d52151d6067627caf618e6167636108dfc0d6f4/editor/src/messages/portfolio/document/graph_operation/graph_operation_message_handler.rs#L205

Undoing Edit> Convert to Infinite Canvas (formerly called 'Clear Artboards') with Ctrl+Z leaves N merge nodes which doesn't seem logical given where transaction added.

https://github.com/user-attachments/assets/2db0178c-b08a-47c3-b71f-712ddcf15e21

Contributor guide

Research direction
Investigate the undo/redo system for 'Convert to Infinite Canvas' action and identify why extra merge nodes remain after undo by tracing the transaction handling in graph operation message handler.rs.
Tech stack
rust
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitRust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75