Tapmoc ignores `kotlin.stdlib.default.dependency=false` in a sub-project's gradle.properties
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- kotlin
- Domain
- build-system
Research direction
Start in tapmoc-gradle-plugin/src/kgp/kotlin/tapmoc/internal/KgpImpl.kt around lines 104-107, where the root project's property is read. Verify how project.findProperty behaves for root and non-root Gradle projects, then confirm the setting is honored in a sub-project while existing root-project behavior remains unchanged.
Written by the indexing model from the issue text.
Description
When setting kotlin.stdlib.default.dependency=false in a non-root Gradle project, Tapmoc nevertheless adds the stdlib to the project dependencies. This is undesirable when creating a shadow Jar in one sub-project and the stdlib dependency should be disabled just there.
This code honors the root project's gradle.properties only:
Replacing it with the following code would make it work for root and non-root gradle.properties:
val isStdlibDefaultDependencyEnabled =
project.findProperty("kotlin.stdlib.default.dependency")?.toString()?.toBooleanStrictOrNull() != false
- Dominant language
- Kotlin
- Stars
- 109
- Forks
- 6
- Avg merge
- 11m
- Merged PRs (30d)
- 3
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from GradleUp/tapmoc
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 52/100
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 58/100
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 45/100
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
bitcoindevkit/bdk-ffi#1125 ·
-
helsemelding-json-schema json-schema-core
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
contributor: external needs review
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100