GoogleContainerTools/skaffold

skaffold pre-build hook can't create input

Open

#7,216 opened on Mar 22, 2022

View on GitHub
 (7 comments) (6 reactions) (0 assignees)Go (12,822 stars) (1,416 forks)batch import
area/hookshelp wantedkind/enhancementkind/starter-projectpriority/p3

Description

Expected behavior

My understanding of the before-build hook was that it should be able to create the inputs used for the build.

Actual behavior

Dependency checking happens before the before-build hook is run and fails as it can't find the data that hasn't been created yet.

Information

  • skaffold v1.35.2
  • Operating system: Ubuntu 18.04
  • Contents of skaffold.yaml:
apiVersion: skaffold/v2beta22
kind: Config
build:
  artifacts:
  - image: makedataimage
    hooks:
      before:
      - command: ["./makedata.sh"]

makedata.sh

#!/bin/bash

echo "XX" > data

Dockerfile

FROM busybox

COPY ./data .

Steps to reproduce the behavior

skaffold build

Generating tags...
 - makedataimage -> makedataimage:latest
Some taggers failed. Rerun with -vdebug for errors.
Checking cache...
 - makedataimage: Error checking cache.
getting hash for artifact "makedataimage": getting dependencies for "makedataimage": file pattern [./data] must match at least one file

Contributor guide

Tech stack
godockerkubernetes
Domain
clibuild system
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programmingUnderstanding of skaffold build system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate the dependency resolution code in skaffold that runs before hooks. Look at how dependencies are gathered for artifacts and ensure that pre build hooks are executed before dependency checking. The relevant code is likely in the build package, particularly the 'DependenciesForArtifact' function. Consider modifying the order of operations or allowing hooks to create dependencies that are then included in the dependency check.