GoogleContainerTools/skaffold

Skaffold should rewrite imagePullPolicy when using a local cluster

Open

#6,992 opened on Jan 5, 2022

View on GitHub
 (3 comments) (2 reactions) (0 assignees)Go (12,822 stars) (1,416 forks)batch import
area/deployarea/localbugbash/q4-2022help wantedkind/frictionpriority/p3

Description

When using a local cluster like minikube, where the built images are loaded directly into the cluster's container runtime, a user will encounter see a deployment failure should they specify an imagePullPolicy: Always. Skaffold should transform the manifests and either remove such pull-policies or possibly transform them to imagePullPolicy: Never.

Contributor guide

Tech stack
gokubernetesdocker
Domain
clidevopscloud
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic Kubernetes conceptsSkaffold workflow understandingGo familiarity
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate how Skaffold currently handles manifest transformation in deploy steps, likely in `pkg/skaffold/deploy/`. Consider adding a flag or automatic detection of local cluster (e.g., minikube) to rewrite imagePullPolicy to Never or remove it. Review existing code for similar manifest mutations, such as adding labels or namespaces, and follow that pattern. Check comments in the issue for any specific implementation hints.
Skaffold should rewrite imagePullPolicy when using a local cluster · GoogleContainerTools/skaffold#6992 | Good First Issue