GoogleContainerTools/skaffold

skaffold does not handle tilde sign (home directory) under kubectl > manifests

Open

#6,983 opened on Dec 28, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Go (12,822 stars) (1,416 forks)batch import
area/confighelp wantedkind/bugpriority/p3

Description

Related to: https://github.com/GoogleContainerTools/skaffold/issues/2123 and https://github.com/GoogleContainerTools/skaffold/pull/2233

Expected behavior

skaffold should be able to use manifests from files in the home directory

Actual behavior

skaffold fails with:

invalid skaffold config: skaffold config file "skaffold.yml" referenced file "~/.secrets/timescaledb/timescaledb-secrets.yml" that could not be found.

Verify that file "~/.secrets/timescaledb/timescaledb-secrets.yml" referenced in config "skaffold.yml" exists and the path and naming are correct.

Information

  • Skaffold version: v1.35.1
  • Operating system: mac
  • Installed via: Homebrew
  • Contents of skaffold.yaml:
apiVersion: skaffold/v2beta26
kind: Config
metadata:
  name: timescaledb

deploy:
  helm:
    releases:
      - name: timescaledb
        namespace: timescaledb
        createNamespace: true
        chartPath: ../../../shared/charts/timescaledb/charts/timescaledb-single
        valuesFiles:
          - ./services/timescaledb/default_values.yml
        setValues: {}

  kubectl:
    manifests:
      - ./.secrets/timescaledb/timescaledb-secrets.yml
    defaultNamespace: timescaledb

Contributor guide

Tech stack
gokubernetes
Domain
clidevopsdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go languageFile path handlingSkaffold development setup
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Examine how Skaffold resolves file paths in configuration, particularly in the deploy/kubectl manifest handling. Look at the config parsing code in pkg/skaffold/config or similar. Reference related PR #2233 for previous attempts. Implement tilde expansion using os/user or filepath.Clean. Test with a skaffold.yaml referencing files under ~.