GoogleContainerTools/skaffold

Show warning with file list for DEVINIT_REGISTER_BUILD_DEPS error

Open

#5,768 opened on Apr 30, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Go (12,822 stars) (1,416 forks)batch import
area/eventingbugbash/q4-2022help wantedkind/feature-requestplanning/Q2-21priority/p2source/partnerships

Description

In the event of DEVINIT_REGISTER_BUILD_DEPS (failures to configure watcher for build dependencies in dev loop), do not error out deployments altogether. Instead provide the list of files for which watcher setup failed via V2 Event API, show a warning to the user with the file list included and continue with the deployment.

Contributor guide

Tech stack
gokubernetes
Domain
backenddevopsdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Go programmingSkaffold internalsEvent API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the skaffold event system to understand how DEVINIT REGISTER BUILD DEPS errors are currently handled. Look for the code that configures watchers for build dependencies and triggers the error. Investigate the V2 Event API to learn how to emit file list events. Implement changes to output a warning with the list of files for which watcher setup failed, and allow the deployment to continue instead of failing.
Show warning with file list for DEVINIT_REGISTER_BUILD_DEPS error · GoogleContainerTools/skaffold#5768 | Good First Issue