GoogleContainerTools/skaffold

if git is not installed skaffold silently falls back to sha256 tagPolicy

Open

#5,439 opened on Feb 23, 2021

View on GitHub
 (6 comments) (0 reactions) (1 assignee)Go (1,416 forks)batch import
area/taghelp wantedkind/bugpriority/p3

Repository metrics

Stars
 (12,822 stars)
PR merge metrics
 (Avg merge 3d 6h) (16 merged PRs in 30d)

Description

When git is not installed skaffold silently falls back to sha256 tagPolicy ignoring gitCommit tagPolicy. I've got hard time debugging why skaffold works as expected locally but wrong in CI, while versions are same

Expected behavior

FAILURE: git not installed. Can't use specified tagPolicy

Actual behavior

Silent fallback to sha256 tagPolicy. Images tagged with IMAGE_TAG is set to latest

Information

  • Skaffold version: 1.20.0
  • Operating system: all
  • Contents of skaffold.yaml:
apiVersion: skaffold/v2beta9
kind: Config
metadata:
  name: best
build:
  artifacts:
  - image: registry.dummy/best
    context: ./
    docker:
      dockerfile: Dockerfile
  tagPolicy:
    gitCommit:
      variant: AbbrevCommitSha
  local:
    push: true
    useBuildkit: true
deploy:
  helm:
    releases:
      - name: best
         chartPath: helm/best
         values:
            image: registry.dummy/best

Steps to reproduce the behavior

  1. uninstall git
  2. skaffold render
  3. no errors present, image tag set to latest

Contributor guide