GoogleContainerTools/skaffold

With buildpack & auto sync a full re-build happens unpredictably

Open

#5,140 opened on Dec 11, 2020

View on GitHub
 (7 comments) (0 reactions) (0 assignees)Go (12,822 stars) (1,416 forks)batch import
help wantedkind/feature-requestkind/frictionplanning/Q4-21priority/p2

Description

Tested using skaffold 1.17.2

  1. Clone the Cloud Code Go hello-world k8s sample: https://github.com/GoogleCloudPlatform/cloud-code-samples/tree/master/golang/go-hello-world
  2. Configure your build to use buildpacks:
build:
  tagPolicy:
    sha256: {}
  artifacts:
  - image: go-hello-world
    context: .
    buildpack:
      builder: gcr.io/buildpacks/builder:v1
  1. Run skaffold dev
  2. Make a change in main.go

Expected: Skaffolds auto-sync for buildpacks would automtically sync the change without performing a full container rebuild.

Actual: The full build happens.

Note: This only seems to happen unpredictably; in my tests, some changes sync, others trigger a full rebuild (the changes are identical each time - e.g. a simple fmt.Println string modification in this case).

Example output (the first couple changes did a full rebuild, the last change synced).

Contributor guide

Tech stack
godockerkubernetes
Domain
build systemdeveloper experiencetooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programmingDockerKubernetesBuildpack concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate the buildpack sync logic in the skaffold codebase, particularly the artifact sync implementation. Review the issue comments for any clues about when sync succeeds vs fails. Check if there is a race condition or file watching issue. Look at the 'build' and 'sync' packages, e.g., pkg/skaffold/build/buildpack/ and pkg/skaffold/sync/.
With buildpack & auto sync a full re-build happens unpredictably · GoogleContainerTools/skaffold#5140 | Good First Issue