GoogleContainerTools/skaffold

Issue when interpreting paths during sync with skaffold

Open

#5,108 opened on Dec 3, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Go (12,822 stars) (1,416 forks)batch import
area/syncfixithelp wantedkind/bugpriority/p3

Description

Expected behavior

Hi. I have setup skaffold to do file sync. While it works well, there is an issue when interpreting paths during sync.

For eg,

This works:

infer:
   - 'packages/**/src/**/*.*'

This does not work:

infer:
    - './packages/**/src/**/*.*'

Where its the same path but with a ./ in front. So, the file does not get matched during sync:

Information

  • Skaffold version: v1.16.0
  • Operating system: Ubuntu server 20.04

Contributor guide

Tech stack
go
Domain
backenddevops
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programmingUnderstanding of skaffold sync configuration
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Examine the code that handles sync path patterns in skaffold's configuration parsing (likely in packages like 'pkg/skaffold/sync'). Look for where the path is normalized or matched; the issue likely stems from not stripping leading './' before globbing. The fix would involve normalizing paths to remove the './' prefix before pattern matching.