GoogleContainerTools/skaffold

[Feature request] Port forwarding works for all deployed containers

Open

#5,099 opened on Dec 3, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Go (12,822 stars) (1,416 forks)batch import
area/portforwardhelp wantedkind/feature-requestpriority/p2

Description

Related: #3712

Current pod selection logic for port-forwarding excludes images that aren't built by Skaffold. This is similar to log tailing and they both use the same pod selector.

Steps to repro: #5067

Contributor guide

Tech stack
gokubernetes
Domain
devopsinfrastructure
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Go programmingKubernetes basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Examine the pod selector logic in `pkg/skaffold/runner/runner.go` (line 75) and understand how it currently excludes non Skaffold images. Review related issue #3712 and steps in #5067. The goal is to extend the selector to include all deployed containers, similar to log tailing. Focus on modifying the pod selection to not filter out images not built by Skaffold.