GoogleContainerTools/skaffold

Logs are missed after code change

Open

#4,785 opened on Sep 15, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Go (12,822 stars) (1,416 forks)batch import
area/loggingarea/uxgood first issuehelp wantedidekind/bugpriority/p3

Description

copied from https://github.com/GoogleCloudPlatform/cloud-code-intellij-internal/issues/2584#

  • Start a skaffold k8s session with an app that contains a readiness probe (the specific setup with a spring-boot app using Jib)
  • Make a code edit

expected: logs continue streaming actual: some of the application logs are not printed until the readiness probe passes (the theory); e.g. the spring boot start up logs are not printed.

See these comments from the copied issue.

Contributor guide

Tech stack
go
Domain
developer experiencetoolingcloud
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
GoKubernetes conceptsskaffold codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate how skaffold streams logs during a code change when a readiness probe is involved. The issue suggests that logs are missed until the probe passes. Look at the log streaming component (likely in pkg/skaffold/log or similar) and the deployer's handling of pod status. Refer to the comments in the linked internal issue for further clues.
Logs are missed after code change · GoogleContainerTools/skaffold#4785 | Good First Issue