GoogleContainerTools/skaffold

Warn if Docker daemon is out of space

Open

#4,695 opened on Aug 18, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Go (12,822 stars) (1,416 forks)batch import
help wantedkind/frictionkind/todopriority/p3

Description

We've noticed across a couple of friction logs that strange things occur when the Docker daemon is out of space, particularly with minikube.

Before calling docker build, could we check docker system df to make sure there is adequate space and emit a warning if not? This could also be useful as a trigger to prune images during startup (#4693).

NOTE: This would be applicable for both local builds (minikube docker-env) and remote builds.

Contributor guide

Tech stack
godockerkubernetes
Domain
devopstooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of GoUnderstanding of Docker commandsFamiliarity with skaffold build workflow
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Examine the skaffold codebase to locate where `docker build` is invoked, likely in `pkg/skaffold/docker/` or `pkg/skaffold/build/`. Use the Docker client (probably `go dockerclient` or Docker SDK) to call the `SystemDf` API. Implement a check before each build to compare available disk space against a threshold and emit a warning if low. Consider whether to make the threshold configurable. Review any existing warnings in the code for style consistency.
Warn if Docker daemon is out of space · GoogleContainerTools/skaffold#4695 | Good First Issue