GoogleContainerTools/skaffold

Skaffold deployment do not store CHANGE-CAUSE to rollout

Open

#4,667 opened on Aug 14, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Go (12,822 stars) (1,416 forks)batch import
help wantedkind/feature-requestpriority/p2

Description

Expected behavior

Skaffold should save the kubectl command that is making changes to the resource. This is done by the --record flag. More information: checking-rollout-history-of-a-deployment

Actual behavior

kubectl rollout history deployment/api-n production

REVISION  CHANGE-CAUSE
74        <none>
75        <none>
76        <none>
77        <none>
78        <none>

Information

  • Skaffold version: 1.13.0
  • Operating system: Windows

Steps to reproduce the behavior

  1. Deploy a sample app
  2. Run kubectl rollout history deployment/your-app

Contributor guide

Tech stack
gokubernetes
Domain
devopsinfrastructure
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programmingSkaffold development setupKubernetes basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue requests adding the ` record` flag to kubectl commands when deploying. Look at the deployer package (e.g., `pkg/skaffold/deploy`) to find where kubectl apply/rollout commands are constructed. Add the ` record` flag to ensure CHANGE CAUSE is stored. Also check if there are any previous attempts or comments from maintainers in the issue thread.