GoogleContainerTools/skaffold

Load images into minikube rather than replacing host's docker env

Open

#4,654 opened on Aug 12, 2020

View on GitHub
 (2 comments) (1 reaction) (0 assignees)Go (12,822 stars) (1,416 forks)batch import
area/buildhelp wantedkind/feature-requestplatform/minikubepriority/p2

Description

currently in skaffold, if we detect a user has minikube as their active kubecontext, we run a minikube docker-env so that docker commands on the host machine build to minikube's docker daemon. this can cause issues if we're only trying to run a skaffold build while minikube is stopped - something that should be possible, but skaffold can't get around because it only knows to try and use minikube's docker daemon.

instead, we could use minikube cache add on images that are built locally, and do this on push, so builds will still work even when minikube's docker daemon is not accessible.

https://minikube.sigs.k8s.io/docs/handbook/pushing

Contributor guide

Tech stack
godockerkubernetes
Domain
devopsinfrastructure
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
GoDockerKubernetesMinikube
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Look at the current implementation of how skaffold detects minikube context and uses `minikube docker env`. The proposed solution is to use `minikube cache add` to push images to minikube's daemon. Examine the `pkg/skaffold/deploy` or similar package for relevant code. Check the minikube documentation for cache add command. Consider edge cases like minikube not running. The issue suggests doing this on push. Review any linked PRs or comments for more context.