GoogleContainerTools/skaffold

PVC get deleted on clean up (when bound by a Deployment)

Open

#4,366 opened on Jun 21, 2020

View on GitHub
 (15 comments) (14 reactions) (0 assignees)Go (12,822 stars) (1,416 forks)batch import
area/cleanuparea/deployhelp wantedkind/feature-requestpriority/p2

Description

I've used minio as part of a release in Skaffold (sub-chart). link

The helm value of the minio: persistence.enabled is set to true, and a PVC is created for its data. However the PVC get terminated and data is lost when ctrl-c is pressed on Skaffold run. I don't think Skaffold should ever cleanup and delete PVCs.

I can see Skaffold add a clean up label to it, so probably related:

Name:          minio
Namespace:     default
StorageClass:  hostpath
Status:        Bound
Volume:        pvc-4c8b7fd6-c4b9-4281-8984-91064e6ff1ab
Labels:        app=minio
               app.kubernetes.io/managed-by=skaffold-v1.11.0
               chart=minio-5.0.30
               heritage=Helm
               release=file-storage
               skaffold.dev/builder=local
               skaffold.dev/cleanup=true
               skaffold.dev/deployer=helm
               skaffold.dev/docker-api-version=1.40
               skaffold.dev/run-id=1376e569-933e-4669-99e8-42901e3a7e81
               skaffold.dev/tag-policy=git-commit
               skaffold.dev/tail=true
Annotations:   pv.kubernetes.io/bind-completed: yes
               pv.kubernetes.io/bound-by-controller: yes
               volume.beta.kubernetes.io/storage-provisioner: docker.io/hostpath
Finalizers:    [kubernetes.io/pvc-protection]
Capacity:      5Gi
Access Modes:  RWO
VolumeMode:    Filesystem
Mounted By:    minio-678684b4d6-l4dgc

Contributor guide

Tech stack
gokubernetes
Domain
devopsinfrastructurecloud
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Kubernetes PVCSkaffold cleanup process
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the cleanup logic in Skaffold's deploy package, likely in files like pkg/skaffold/deploy/helm.go or pkg/skaffold/deploy/kubectl.go, where resources with the label 'skaffold.dev/cleanup=true' are deleted. Determine why PVCs bound by Deployments are also deleted and propose a fix to exclude PVCs from cleanup.