GoogleContainerTools/skaffold

Skaffold push always HTTPS despite insecure-registry flags

Open

#4,310 opened on Jun 11, 2020

View on GitHub
 (10 comments) (0 reactions) (0 assignees)Go (12,822 stars) (1,416 forks)batch import
area/registryhelp wantedkind/bugpriority/p3

Description

As part of a CI pipeline, I'm running a local registry, which is by default insecure: docker run -d --name registry.localhost -v local_registry:/var/lib/registry --rm -p 5000:5000 registry:2

I'm definitely able to resolve the registry (eg my /etc/hosts mappings are all good), however passing:

SKAFFOLD_DEFAULT_REPO="registry.localhost:5000"  skaffold build --insecure-registry=registry.localhost --insecure-registry=registry.localhost:5000 --cache-artifacts=false

Gives me:

couldn't build "blah": could not push image "registry.localhost:5000/blah:7d38d94d5b9-dirty": Get https://registry.localhost:5000/v2/: Service Unavailable

Expected behavior

At the very least, I'd have expected it to try and push to the http endpoint - http://registry.localhost:5000/v2

Actual behavior

It tries to push to https://registry.localhost:5000/v2

Information

  • Skaffold version: v1.10.1
  • Operating system: OSX

What might I be missing here? I've also tried the environment variable way of specifying the insecure registries. Does this only work with skaffold dev perhaps?

Contributor guide

Tech stack
godocker
Domain
backenddevops
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
DockerSkaffold basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate how skaffold handles insecure registries during push. Look at the push command implementation, likely in pkg/skaffold/docker/push.go or similar. Check how the insecure registry flag is passed to the image push library (probably go containerregistry). Consider if the flag only affects 'skaffold dev' and not build/push. Review existing comments for any identified code locations.