GoogleContainerTools/skaffold

Allow default dev cleanup mode to be set in skaffold.yaml

Open

#4,268 opened on May 27, 2020

View on GitHub
 (7 comments) (1 reaction) (0 assignees)Go (1,416 forks)batch import
area/configfixithelp wantedkind/feature-requestpriority/p3

Repository metrics

Stars
 (12,822 stars)
PR merge metrics
 (Avg merge 1d 18h) (18 merged PRs in 30d)

Description

Currently skaffold dev defaults to cleanup=true.

There are occasions when I'd like to modify this behavior for all users of a specific project profile. The simplest way to do that would be a cleanup setting in skaffold.yaml.

The CLI flag would still override the setting in skaffold.yaml.

After discussion in office hours, we determined this feature might be useful but could be confusing for some use cases. Open to discussion as always :-)

Original Question: https://groups.google.com/forum/#!topic/skaffold-users/rqzKmFI-qaM

Contributor guide

Research direction
Examine the current implementation of the `dev` command and how it handles the `cleanup` flag. Then, add a `cleanup` field to the Skaffold pipeline config (likely in `pkg/skaffold/config/config.go` or similar) and integrate it with the flag logic so that the YAML value is used unless the flag is explicitly set.
Tech stack
go
Domain
cli
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75