GoogleContainerTools/skaffold

Use enum instead of string for "InProgress" , "Succeeded", "Started", "Failed"

Open

#2,967 opened on Oct 1, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Go (12,822 stars) (1,416 forks)batch import
area/eventingbugbash/q4-2022help wantedkind/todopriority/p3

Description

Expected behavior

Currently we have "Build Complete", "Deploy Complete" as status messages when a build or deploy successfully complete.

While "Deploy Failed" and "Build Failed" when build or deploy failed.

After discussion with IDE teams, they mentioned we could change it to "Succeeded" instead of "Complete" to be in sync with "Failed".

Contributor guide

Tech stack
go
Domain
clibackenddevops
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programmingFamiliarity with skaffold build/deploy workflows
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Search for string literals like "Build Complete", "Deploy Complete", "Build Failed", "Deploy Failed" in the codebase, likely in files under pkg/skaffold/build/ and pkg/skaffold/deploy/. Also check for existing enum patterns in the project. Define a new enum type (e.g., Status) with iota values for InProgress, Succeeded, Started, Failed, and replace all occurrences. Ensure consistency with any existing status enums.
Use enum instead of string for "InProgress" , "Succeeded", "Started", "Failed" · GoogleContainerTools/skaffold#2967 | Good First Issue