GoogleContainerTools/skaffold

Use enum instead of string for "InProgress" , "Succeeded", "Started", "Failed"

Open

#2,967 opened on Oct 1, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Go (1,416 forks)batch import
area/eventingbugbash/q4-2022help wantedkind/todopriority/p3

Repository metrics

Stars
 (12,822 stars)
PR merge metrics
 (Avg merge 3d 6h) (16 merged PRs in 30d)

Description

Expected behavior

Currently we have "Build Complete", "Deploy Complete" as status messages when a build or deploy successfully complete.

While "Deploy Failed" and "Build Failed" when build or deploy failed.

After discussion with IDE teams, they mentioned we could change it to "Succeeded" instead of "Complete" to be in sync with "Failed".

Contributor guide

Research direction
Replace the string constants with an enum type, then update all references in the codebase.
Tech stack
go
Domain
backendtooling
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75