GoogleCloudPlatform/cloud-opensource-java

Group linkage error info in plugin

Open

#576 opened on Apr 19, 2019

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Java (80 forks)auto 404
enhancementgood first issuep3

Repository metrics

Stars
 (162 stars)
PR merge metrics
 (PR metrics pending)

Description

Currently it looks something like this:

mockito-core-2.18.0.jar (2 errors): org.mockito.internal.creation.bytebuddy.MockMethodDispatcher is not found, referenced from org.mockito.internal.creation.bytebuddy.MockMethodAdvice$ForReadObject org.mockito.internal.creation.bytebuddy.MockMethodDispatcher is not found, referenced from org.mockito.internal.creation.bytebuddy.MockMethodAdvice$ForEquals org.mockito.internal.creation.bytebuddy.MockMethodDispatcher is not found, referenced from org.mockito.internal.creation.bytebuddy.MockMethodAdvice$SerializableRealMethodCall org.mockito.internal.creation.bytebuddy.MockMethodDispatcher is not found, referenced from org.mockito.internal.creation.bytebuddy.InlineBytecodeGenerator org.mockito.internal.creation.bytebuddy.MockMethodDispatcher is not found, referenced from org.mockito.internal.creation.bytebuddy.MockMethodAdvice org.mockito.internal.creation.bytebuddy.MockMethodDispatcher is not found, referenced from org.mockito.internal.creation.bytebuddy.MockMethodAdvice$ForHashCode org.mockito.internal.creation.bytebuddy.MockMethodDispatcher.get is not found, referenced from org.mockito.internal.creation.bytebuddy.MockMethodAdvice$ForReadObject org.mockito.internal.creation.bytebuddy.MockMethodDispatcher.get is not found, referenced from org.mockito.internal.creation.bytebuddy.MockMethodAdvice$ForEquals org.mockito.internal.creation.bytebuddy.MockMethodDispatcher.isMock is not found, referenced from org.mockito.internal.creation.bytebuddy.MockMethodAdvice$ForEquals org.mockito.internal.creation.bytebuddy.MockMethodDispatcher.get is not found, referenced from org.mockito.internal.creation.bytebuddy.MockMethodAdvice$SerializableRealMethodCall org.mockito.internal.creation.bytebuddy.MockMethodDispatcher.set is not found, referenced from org.mockito.internal.creation.bytebuddy.InlineBytecodeGenerator org.mockito.internal.creation.bytebuddy.MockMethodDispatcher. is not found, referenced from org.mockito.internal.creation.bytebuddy.MockMethodAdvice org.mockito.internal.creation.bytebuddy.MockMethodDispatcher.get is not found, referenced from org.mockito.internal.creation.bytebuddy.MockMethodAdvice org.mockito.internal.creation.bytebuddy.MockMethodDispatcher.isMocked is not found, referenced from org.mockito.internal.creation.bytebuddy.MockMethodAdvice org.mockito.internal.creation.bytebuddy.MockMethodDispatcher.isOverridden is not found, referenced from org.mockito.internal.creation.bytebuddy.MockMethodAdvice org.mockito.internal.creation.bytebuddy.MockMethodDispatcher.handle is not found, referenced from org.mockito.internal.creation.bytebuddy.MockMethodAdvice org.mockito.internal.creation.bytebuddy.MockMethodDispatcher.get is not found, referenced from org.mockito.internal.creation.bytebuddy.MockMethodAdvice$ForHashCode org.mockito.internal.creation.bytebuddy.MockMethodDispatcher.isMock is not found, referenced from org.mockito.internal.creation.bytebuddy.MockMethodAdvice$ForHashCode

  1. We should organize this a little better when the same missing method is found with multiple sources. E.g.

    mockito-core-2.18.0.jar (2 errors): org.mockito.internal.creation.bytebuddy.MockMethodDispatcher is not found, referenced from

    • org.mockito.internal.creation.bytebuddy.MockMethodAdvice$ForReadObject
    • org.mockito.internal.creation.bytebuddy.MockMethodAdvice$ForEquals
    • org.mockito.internal.creation.bytebuddy.MockMethodAdvice$SerializableRealMethodCall * org.mockito.internal.creation.bytebuddy.InlineBytecodeGenerator * org.mockito.internal.creation.bytebuddy.MockMethodAdvice *org.mockito.internal.creation.bytebuddy.MockMethodAdvice$ForHashCode

  2. Furthermore, when an entire class is not found, as here, we don't need to bother printing individual missing method and missing field errors from that class.

Contributor guide

Research direction
Examine the error output logic in the plugin and modify it to group errors by missing class or method, reducing redundancy when a whole class is missing.
Tech stack
java
Domain
developer experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Java
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60