GoogleCloudPlatform/cloud-opensource-java

LinkageCheckerMain to provide clear error message when the supplied coordinates are invalid

Open

#1,948 opened on Feb 19, 2021

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Java (80 forks)auto 404
buggood first issuehelp wantedp2

Repository metrics

Stars
 (162 stars)
PR merge metrics
 (PR metrics pending)

Description

When I pass an invalid coordinates to LinkageCheckerMain, it throws IndexOutOfBoundsException. This does not tell the cause of the error.

> Task :checkJavaLinkage
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
Exception in thread "main" java.lang.IndexOutOfBoundsException: end index (1) must not be greater than size (0)
        at com.google.common.base.Preconditions.checkPositionIndexes(Preconditions.java:1420)
        at com.google.common.collect.ImmutableList.subList(ImmutableList.java:433)
        at com.google.cloud.tools.opensource.classpath.LinkageCheckerMain.checkArtifacts(LinkageCheckerMain.java:159)
        at com.google.cloud.tools.opensource.classpath.LinkageCheckerMain.main(LinkageCheckerMain.java:66)

> Task :checkJavaLinkage FAILED

Contributor guide

Research direction
Examine how coordinates are parsed in LinkageCheckerMain. Add input validation to check for valid format and provide a descriptive error message if invalid.
Tech stack
java
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJava
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75