GoogleChromeLabs/squoosh

SVG scaling bug

Open

#530 opened on Mar 29, 2019

View on GitHub
 (2 comments) (1 reaction) (0 assignees)TypeScript (20,335 stars) (1,431 forks)batch import
UIgood first issuehelp wanted

Description

Here’s a fun one: This SVG of the Rust mascot behaves weirdly when being resized with Squoosh. My hunch is it’s gotta do with the viewbox, but @jakearchibald knows SVG much better than I do. PTAL?

SVG: rustacean-flat-happy.svg.zip

Kapture 2019-03-29 at 17 10 41

(lol @ GitHub allowing .zip but not .svg)

Contributor guide

Tech stack
javascripttypescripthtmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
SVG viewBox understandingReproduce the bug with provided file
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the viewBox attribute of the provided SVG file and examine Squoosh's image resizing logic. Look for any viewBox related transformations in the codebase, likely in the SVG input handling component. Consider reaching out to @jakearchibald for SVG expertise as suggested in the issue.