GoogleChromeLabs/quicklink

site: use the files from dist folder instead of the CDN

Open

#389 opened on Jun 16, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (10,861 stars) (431 forks)batch import
docsenhancementgood first issuehelp wanted

Description

Not sure how to load the dist folder which is one folder up from site.

This should make sure PR previews use the latest code plus we should be able to add SRI hashes later (see #336).

Contributor guide

Tech stack
javascripthtml
Domain
frontendbuild system
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Understanding of project's build processFamiliarity with site folder
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the `site/` directory and how it currently references the CDN files. Determine how to load the `dist/` folder from a relative path. Review existing build scripts (likely in package.json) to ensure the `dist/` folder is built. Consider integrating SRI hashes as mentioned in issue #336. Test via PR previews.