GoogleChromeLabs/quicklink

Do not prefetch links with `download` attribute

Open

#181 opened on May 15, 2020

View on GitHub
 (1 comment) (1 reaction) (0 assignees)JavaScript (10,861 stars) (431 forks)batch import
enhancementgood first issue

Description

Is your feature request related to a problem? Please describe. Currently all links are prefetched including ones intended for downloadable assets. Since these links could point to large payloads (imagine multi megabyte PDFs or zip archives) that's quite a waste of bandwidth.

I'd argue excluding links which have the download attribute would be a sensible default.

Describe the solution you'd like

document.querySelectorAll('a:not([download])')

Thank you :)

Contributor guide

Tech stack
javascripthtml
Domain
frontendperformance
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic JavaScriptDOM querySelectorsQuicklink library structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Locate the code in quicklink's source where links are selected for prefetching, likely in the main prefetch function. Modify the query selector to exclude links with the `download` attribute. Ensure that the change is applied consistently across any link collection logic. No additional changes required beyond the selector update.