GoogleChrome/lighthouse

Canonical URL audit mistakes invalid URLs for relative ones

Open

#12008 opened on Jan 26, 2021

View on GitHub
 (7 comments) (0 reactions) (0 assignees)JavaScript (27,768 stars) (9,278 forks)batch import
P3good first issue

Description

Provide the steps to reproduce

  1. Run LH on https://output.jsbin.com/vulerujohi for just the canonical audit

What is the current behavior?

The audit fails with explanation Relative URL (https:// example.com)

What is the expected behavior?

The audit fails with explanation Invalid URL (https:// example.com)

Environment Information

  • Affected Channels: CLI, Node, DevTools
  • Lighthouse version: 7.0.1
  • Chrome version: 88.0.4324.96
  • Node.js version: 14.15.4
  • Operating System: macOS Mojave 10.14.6

Contributor guide

Tech stack
javascriptnodejs
Domain
frontendperformance
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with Lighthousebasic JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
The issue is that the canonical URL audit incorrectly labels a URL with a space after 'https://' as 'Relative URL' instead of 'Invalid URL'. The fix is to locate the audit logic, likely in `lighthouse core/audits/seo/canonical.js` or similar, find the condition that outputs 'Relative URL', and change it to 'Invalid URL'. The test file for this audit should also be updated to reflect the corrected message.