GlowstoneMC/Glowstone

Player MapView sending API

Open

#572 opened on Oct 13, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Java (1,825 stars) (278 forks)batch import
Category: server featurePriority: minorStatus: in progressType: featuregood first issue

Description

The API to send MapViews to a Player isn't implemented: https://github.com/GlowstoneMC/Glowstone/blob/12ed57cc436ee2b525d740bef2b855150fe0bd24/src/main/java/net/glowstone/entity/GlowPlayer.java#L2247-L2249

This should send a packet (MapDataMessage) that sends the data inside of the MapView.

To check:

  • If the codec for encoding MapDataMessage is up-to-date with the documentation
  • If there are other parts of the MapView API that aren't implemented (not required in the scope of this issue)

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Contributor guide

Tech stack
java
Domain
backendapi
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Java knowledgeMinecraft protocol basicsFamiliarity with networking codecs
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
The main task is to implement the missing API call in GlowPlayer.java around line 2247-2249 to send a MapDataMessage packet. First, verify that the MapDataCodec (src/main/java/net/glowstone/net/codec/play/game/MapDataCodec.java) is up to date with the protocol documentation at http://wiki.vg/Protocol#Map. If the codec is incorrect, update it. Then, in the MapView sending method, construct and send the MapDataMessage using the player's session. Additionally, check if any other MapView API methods are unimplemented but this is optional. Test by running a local server and using a map item in game to see if the map data is transmitted correctly.