GlowstoneMC/Glowstone

Enchantment books fail to combine on first try

Open

#450 opened on Mar 30, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (1,825 stars) (278 forks)batch import
Category: gameplay featurePriority: minorhelp wanted

Description

Solely trying to combine enchantment books without renaming will fail on the first try, due to client and server item slot conflict.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Contributor guide

Tech stack
java
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
JavaMinecraft enchanting mechanicsserver client netcode
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate Glowstone's inventory handling logic for enchantment combining. The issue suggests a client server slot conflict. Look at classes related to `InventoryClickEvent` and `Enchantment` in the codebase. Check if there are any existing tests for combining enchantment books. Since the issue is old and lacks details, reproduce the bug on a recent version of Glowstone to understand the exact failure.