Glavin001/tslint-clean-code
View on GitHubUse Array.prototype.find() instead of .filter()[0]
Open
#56 opened on Jul 11, 2018
good first issuehelp wanted
Repository metrics
- Stars
- (175 stars)
- PR merge metrics
- (No merged PRs in 30d)
Description
See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/find
const items = [
{ id: 123 },
{ id: 456 }
// ...
];
const selectedId = 456;
const selectedItem = items.filter(item => item.id === selectedIds)[0];
Should be:
// ...
const selectedItem = items.find(item => item.id === selectedIds);
Diff:
- const selectedItem = items.filter((item) => item.id === selectedIds)[0];
+ const selectedItem = items.find((item) => item.id === selectedIds);