Glavin001/tslint-clean-code

New rule: avoid-if-else

Open

#39 opened on Jan 28, 2018

View on GitHub
 (3 comments) (1 reaction) (0 assignees)TypeScript (15 forks)github user discovery
good first issuerule

Repository metrics

Stars
 (175 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

http://blog.timoxley.com/post/47041269194/avoid-else-return-early

Use of if-else is always unnecessary, and leads to cyclomatic complexity. Other clean code linters (phpmd, golint) enforce this pattern. Would love to have this rule as I have to enforce it manually in my typescript projects right now.

Contributor guide

Research direction
Study existing 'no else return' rules in ESLint and other linters, then implement a similar rule in TSLint following its rule API.
Tech stack
typescript
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptTSLint rule development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60