Removing channel members doesn't send a system message
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 58/100
Research direction
Start in Channel.php, comparing removeMembers with addMembers and the documented channel-member removal options. Verify how the optional options are passed through and confirm that removal can produce the documented system message behavior; update or run the relevant existing checks if present.
Written by the indexing model from the issue text.
Description
When adding users to a channel, you can pass on the option to also send a system message to the channel (I use it to notifiy channel members with a message like " has been added to this channel". The documentation cover this pretty well. The documentation also states that this is possible when removing members from a channel.
However, the removeMembers function in Channel.php only accepts an array of userIds, and nothing else. Comparing it to addMembers, it seems like it's missing a second parameter $options to be able to pass on options such as a system message.
Would it be possible to add the $options optional parameter in the removeMembers function, so that it behaves similarly to the addMembers function?
- Dominant language
- PHP
- Stars
- 29
- Forks
- 9
- Avg merge
- 11h 38m
- Merged PRs (30d)
- 2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from GetStream/stream-chat-php
-
Difficulty 1/5 Under an hour Newbie friendliness 65/100
GetStream/stream-chat-php#140 ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
GetStream/stream-chat-php#151 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 42/100
GetStream/stream-chat-php#114 · 2 comments ·
All issues in GetStream/stream-chat-php
Similar issues
-
priority: p3
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
googleapis/librarian#7636 ·
-
0. Needs triage bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
nextcloud/fulltextsearch#1011 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
phpstan/phpstan-doctrine#794 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Automattic/static-site-importer#1767 ·