Review ROUNDING during computations. Is this rounding necessary? Beneficial?
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 45/100
Research direction
Start by reading GeodePy.ntv2reader.py functions ntv2_bicubic() and ntv2_bilinear(), then GeodePy.convert.geo2grid(), focusing on where latitude, longitude, Easting, and Northing values are rounded. Compare the current precision with the requested full or greater precision and establish the intended output behavior before changing it; the issue is done when the rounding policy is decided and applied consistently.
Written by the indexing model from the issue text.
Description
In general, the precision returned by GeodePy are suitable for the average (or great majority of) use case.
There MAY be cases, however, where a user wants to make comparisons of outputs at greater precision.
There seems no need to artificially round to the given precisions.
Consider returning the full float, or rounding to even greater precision.
GeodePy.ntv2reader.py ntv2_bicubic() and GeodePy.ntv2reader.py ntv2_bilinear()
round their lat and lon shift values (in arc seconds) to 6 decimal places (equivalent to approx 3/100th of a mm).
GeodePy.convert.geo2grid()
rounds Easting and Northing outputs (in metres) to 4 decimal places.
- Dominant language
- Python
- Stars
- 117
- Forks
- 50
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from GeoscienceAustralia/GeodePy
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
GeoscienceAustralia/GeodePy#169 ·
-
Difficulty 1/5 1-3 hours Newbie friendliness 62/100
GeoscienceAustralia/GeodePy#100 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 52/100
GeoscienceAustralia/GeodePy#170 ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
GeoscienceAustralia/GeodePy#150 ·
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
GeoscienceAustralia/GeodePy#132 ·
All issues in GeoscienceAustralia/GeodePy
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
use-agent-os/agent-os#3314 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
BasedHardware/omi#15662 · 1 comment ·
-
documentation help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
AiursoftWeb/AnduinOS-2#19 ·