Galooshi/import-js

ImportJS misidentifies `import` methods to be Dynamic Import

Open

#529 opened on Mar 18, 2019

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (70 forks)batch import
bughelp wanted

Repository metrics

Stars
 (519 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I just run ImportJS on a huge codebase and the results are mostly good, but this one seemed peculiar enough for me to report it:

I'm not too familiar with the lib, but in this case it broke the code by sorting two variable assignments in false order.

Used ImportJS 3.2.0 on Mac OS, via CLI:

find ./client -name "**.js*" -exec importjs fix --overwrite {} \;

//.importjs.js
module.exports = {
    declarationKeyword: 'import',
    environments: ['meteor', 'node'],
    excludes: ['.meteor/local/**', '.vscode/**'],
    mergableOptions: {
        globals: false,
    },
    useRelativePaths: true
}

Contributor guide

Research direction
Investigate the parsing logic in ImportJS that distinguishes static imports from dynamic imports. Look for how the tool identifies `import()` expressions vs. static `import` statements, as the bug shows it misclassifies method calls named 'import' as dynamic imports. Check the AST traversal or regex patterns used.
Tech stack
javascriptnodejs
Domain
clitooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70