Galooshi/import-js

ImportJS misidentifies `import` methods to be Dynamic Import

Open

#529 opened on Mar 18, 2019

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (519 stars) (70 forks)batch import
bughelp wanted

Description

I just run ImportJS on a huge codebase and the results are mostly good, but this one seemed peculiar enough for me to report it:

I'm not too familiar with the lib, but in this case it broke the code by sorting two variable assignments in false order.

Used ImportJS 3.2.0 on Mac OS, via CLI:

find ./client -name "**.js*" -exec importjs fix --overwrite {} \;

//.importjs.js
module.exports = {
    declarationKeyword: 'import',
    environments: ['meteor', 'node'],
    excludes: ['.meteor/local/**', '.vscode/**'],
    mergableOptions: {
        globals: false,
    },
    useRelativePaths: true
}

Contributor guide

Tech stack
javascript
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic knowledge of JavaScript module systemUnderstanding of static vs dynamic imports
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
The issue reports that ImportJS incorrectly identifies certain import methods as dynamic imports, causing incorrect sorting of variable assignments. Investigate the parsing logic in the source code, likely in the `import js` package's detection of import statements. Look at how the library distinguishes between static and dynamic imports, and check for any edge cases in regex or AST parsing. The screenshot shows an example where two import like lines are sorted wrongly. Focus on the function that handles import identification and sorting, and try to reproduce the issue with the provided configuration.