Galooshi/import-js

`export interface` not supported in Flow

Open

#494 opened on Apr 10, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (70 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (519 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Flow supports export interface, but importjs doesn't pick up on these statements when auto-importing.

A workaround is to use the same workaround as for older Flow versions:

interface iMyInterface { ... }
export type IMyInterface = iMyInterface

It would be nice if import-js supported the shorter export interface... syntax since Flow now supports it.

cf. https://github.com/facebook/flow/issues/1131

Contributor guide

Research direction
Investigate how import js parses export statements (likely in lib/ or src/), find the handling for export type and extend it to also support export interface syntax. Look for any existing tests for export parsing and add a test case for export interface.
Tech stack
javascript
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75