Gallopsled/pwntools

shellcraft.mov does not support AH, BH, etc. registers

Open

#1,046 opened on Oct 8, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (1,684 forks)batch import
Hacktoberfestenhancementhelp-wantedshellcode

Repository metrics

Stars
 (11,127 stars)
PR merge metrics
 (Avg merge 18d 5h) (5 merged PRs in 30d)

Description

from pwn import *
# context.arch = 'i386'
print shellcraft.mov('eax', 'ah')

Expected: movzx eax, ah

Result:

NameError: name 'ah' is not defined

The error is raised when trying to eval ah as a system-constant value

But the real reason is ah is not defined in shellcraft/registers.py as a register in i386.

Issue occurs in amd64 as well.

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.