FuelLabs/sway

Add "definition dominates use" check in the IR verifier

Open

#3,164 opened on Oct 27, 2022

View on GitHub
 (2 comments) (1 reaction) (0 assignees)Rust (5,421 forks)batch import
compilercompiler: irenhancementgood first issueteam:compiler

Repository metrics

Stars
 (61,702 stars)
PR merge metrics
 (Avg merge 22h 6m) (16 merged PRs in 30d)

Description

With #3128 , we now have a dominator tree. Use that to verify that every SSA definition dominates its uses.

Contributor guide

Research direction
Examine the dominator tree structure from #3128 and implement a traversal over IR instructions to ensure each definition's use is dominated by its definition. Start by looking at how dominates() is implemented and then iterate over all instructions.
Tech stack
rust
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RustCompilerSSADominator Tree
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30