FuelLabs/sway

Add "definition dominates use" check in the IR verifier

Open

#3,164 opened on Oct 27, 2022

View on GitHub
 (2 comments) (1 reaction) (0 assignees)Rust (61,702 stars) (5,421 forks)batch import
compilercompiler: irenhancementgood first issueteam:compiler

Description

With #3128 , we now have a dominator tree. Use that to verify that every SSA definition dominates its uses.

Contributor guide

Tech stack
rust
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
SSA formDominator treeRustCompiler IR
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Review the dominator tree implementation from PR #3128. Then explore the IR verifier module in sway core/src/ir/ to understand how SSA definitions are structured. Look for existing verification functions to model the new check. The issue is clear but requires familiarity with compiler internals.