FuelLabs/fuels-rs

Add clippy check for overflowing arithmetic

Open

#1,238 opened on Dec 14, 2023

View on GitHub
 (0 comments) (0 reactions) (1 assignee)Rust (43,211 stars) (1,360 forks)batch import
Securitygood first issuetech-debtv1.0

Description

Our fuzzing efforts have mainly discovered unchecked arithmetic. We should add the following clippy check to our CI to disallow unchecked arithmetic in the future: https://rust-lang.github.io/rust-clippy/master/index.html#/arithmetic_side_effects

Contributor guide

Tech stack
rust
Domain
ci cddeveloper experience
Issue type
chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
RustCI configurationclippy
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The CI configuration is likely in a GitHub Actions workflow file (e.g., .github/workflows/ci.yml). The assignee may already be working on this issue. To proceed, review the current workflow and add the clippy flag ` D clippy::arithmetic side effects`. See the clippy documentation linked in the issue for details.
Add clippy check for overflowing arithmetic · FuelLabs/fuels-rs#1238 | Good First Issue