FuelLabs/fuel-core

Unify defaults for config

Open

#975 opened on Feb 2, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Rust (57,084 stars) (2,861 forks)batch import
fuel-coregood first issuetech-debt

Description

The cli run: https://github.com/FuelLabs/fuel-core/blob/3a88bececec821bf8ebbc33d001b84f34968a191/bin/fuel-core/src/cli/run.rs#L62 has a set of defaults that duplicate and are sometimes different to the actual defaults for the real config. We should unify these values so there is a single source of truth.

Contributor guide

Tech stack
rust
Domain
clideveloper experience
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rustfuel core CLI config
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Start by examining the defaults defined in bin/fuel core/src/cli/run.rs line 62 and compare them with the actual defaults for the config struct in the codebase. Identify any discrepancies or duplication. Then propose a refactor to centralize default values into a single source of truth, possibly by moving them to a common location or using a default implementation.
Unify defaults for config · FuelLabs/fuel-core#975 | Good First Issue