FuelLabs/fuel-core

Avoid cloning of vectors in `HexString`

Open

#2,657 opened on Feb 1, 2025

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (57,084 stars) (2,861 forks)batch import
good first issue

Description

The GraphQL server coverts bytes into the hex string to return it to the user. During this convert process, we take vector by value.

We have many cases where we clone vectors instead of passing it as a reference.

This issue is created to replace Vec<u8> with Cow<[u8]> or Cow<Vec<u8>> and allow usage of references.

Contributor guide

Tech stack
rust
Domain
backendapiperformance
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Rust ownershipCow<[u8]> pattern
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue involves replacing `Vec<u8>` with `Cow<[u8]>` or `Cow<Vec<u8>>` in the hex string conversion within the GraphQL server. Start by searching for functions that take `Vec<u8>` by value and call `clone()` on it. Examine the conversion logic in the GraphQL server code, likely in files related to hex encoding. Check the existing comments and PRs for any prior discussions or approaches.
Avoid cloning of vectors in `HexString` · FuelLabs/fuel-core#2657 | Good First Issue