FuelLabs/fuel-core

Separate Execution Gas Price and DA Gas Price into separate newtypes to add clarity

Open

#2,382 opened on Oct 22, 2024

View on GitHub
 (2 comments) (0 reactions) (1 assignee)Rust (57,084 stars) (2,861 forks)batch import
good first issue

Description

It's been suggested that we separate the two just to help organize the code a bit better. Instead of just dealing withu64 everywhere, it could help the reader to have types to communicate everywhere in the code the purpose of the numbers.

Contributor guide

Tech stack
rust
Domain
backendblockchain
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic Rust knowledgeUnderstanding of gas pricing in FuelFamiliarity with newtype pattern
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Review the discussion in PR #2364, specifically the comment that suggested separating the types. Then identify all occurrences of `u64` representing gas prices in the codebase, distinguishing between execution gas price and DA gas price. Create two newtypes, e.g., `ExecutionGasPrice` and `DaGasPrice`, implementing necessary traits (e.g., arithmetic, serialization), and refactor all usages to use them. Consult the linked PR for additional context and potential pitfalls.
Separate Execution Gas Price and DA Gas Price into separate newtypes to add clarity · FuelLabs/fuel-core#2382 | Good First Issue