Remove "frameborder" attribute from iframe
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 82/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- typescript
- Domain
- frontend
Research direction
Open src/sdk/create.ts and inspect line 83, where the iframe is created. Remove the obsolete frameborder attribute and verify that the SDK-generated iframe no longer includes it while retaining the intended border styling.
Written by the indexing model from the issue text.
Description
The frameborder attribute is obsolete in HTML5 and shouldn't be used in FriendlyCaptcha.
Using the obsolete frameborder attribute on an <iframe> is discouraged because it is no longer part of modern HTML standards and is ignored by many contemporary browsers. Instead of relying on outdated, browser‑specific behavior, developers should use CSS to control the visual presentation of iframes.
Todo:
- Remove line 83 of https://github.com/FriendlyCaptcha/friendly-captcha-sdk/blob/main/src/sdk/create.ts
- Replacing frameborder="0" with a CSS rule such as iframe { border: none; } ensures cleaner, more maintainable code and better compatibility with current and future web technologies.
This approach aligns with modern best practices and keeps your markup semantically correct, accessible, and easier to style consistently across your project.
- Dominant language
- TypeScript
- Stars
- 34
- Forks
- 15
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 5
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from FriendlyCaptcha/friendly-captcha-sdk
-
I Open
Difficulty 5/5 Over a week Newbie friendliness 1/100
-
Difficulty 5/5 Over a week Newbie friendliness 30/100
FriendlyCaptcha/friendly-captcha-sdk#87 · 2 comments ·
All issues in FriendlyCaptcha/friendly-captcha-sdk
Similar issues
-
calcite-components needs triage refactor
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Esri/calcite-design-system#15203 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 91/100
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 95/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100