FremyCompany/css-grid-polyfill

Height not being set for container if box-sizing is not content-box and element has border/padding

Open

#46 opened on Mar 8, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (90 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (1,115 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hello,

I have a container height issue with all the tests I have been able to do on Edge. The polyfill gives a position: absolute and fixed height on each grid item, but the container doesn't compute it's children's height, so they overflow.

Codepen : http://codepen.io/raphaelgoetter/pen/ZQLBxd Screenshots : http://www.hostingpics.net/viewer.php?id=700041edgepolyfill.png

Contributor guide

Research direction
Investigate the calculation of container height in the polyfill when box sizing is not content box. Check how the polyfill accounts for padding and border in the height calculation of grid items and the container.
Tech stack
javascriptcss
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
CSSJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75