FormidableLabs/rapscallion

dangerouslySetInnerHTML fails with arrays

Open

#100 opened on Jun 16, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (68 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (1,397 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

If you attempt to render a tag such as this:

<p dangerouslySetInnerHTML={{
		__html: content,
}}/>

where content is an array, Rapscallon will fail on the adler checksum generator:

/Users/gcp/Thumbtack/universal-frontend/node_modules/@thumbtack/rapscallion/lib/adler32.js:28
    b += a += data.charCodeAt(i);
                   ^

TypeError: data.charCodeAt is not a function

renderToString() allows for arrays, so it seems like we should handle them here. I can fix by specifying content[0] (all of the arrays I'm dealing with at the moment are 1-length), though I'd need to do some additional research to know exactly what React is expected to output when an array is provided.

Contributor guide

Research direction
Understand how React handles arrays in dangerouslySetInnerHTML and implement a check in the adler32 checksum generator to convert or handle array input.
Tech stack
javascriptreactnodejs
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70