FormidableLabs/radium

Radium seems to slow down framerates

Open

#389 opened on Oct 20, 2015

View on GitHub
 (7 comments) (0 reactions) (0 assignees)JavaScript (7,414 stars) (352 forks)batch import
docshelp wanted

Description

Hi , i have made a simple test with react motion.

As soon as i add the @Radium decorator it slows down quite a lot. The difference isn't really noticable on desktop, but on a mobile device it is a big difference.

please see the tests here : https://github.com/Aaike/react-motion-radium-test There are links to 2 tests. The only difference in the 2 demos is the addition of the @Radium decorator.

Please look at those tests with a chrome browser on a mobile device.

Do you have any suggestions to avoid this drop in performance ?

Contributor guide

Tech stack
reactjavascript
Domain
frontendperformance
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
ReactRadium
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
The issue reports performance slowdown with Radium decorator on mobile. The reporter provided a test repo (https://github.com/Aaike/react motion radium test). Investigate using React Profiler to identify costly renders. Look at Radium's source code for any unnecessary re renders or heavy computations. Consider implementing shouldComponentUpdate or using PureComponent to mitigate the issue.